Skip to content

[backport core/1.33] Restore Cancel Button #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 3 commits into from
Dec 9, 2025
Merged

[backport core/1.33] Restore Cancel Button #7266

christian-byrne merged 3 commits into from
Dec 9, 2025

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Dec 9, 2025 •
edited by sync-by-unito bot
Loading

Backport of 259e956 to core/1.33. Resolved conflicts in TopMenuSection.vue and reverted binary snapshots.

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu
Hotfix: restore cancel button in top menu (#7234)
7cc9cac 
## Summary
- restore the interrupt/cancel button in the top menu action bar

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7234-Hotfix-restore-cancel-button-in-top-menu-2c36d73d365081b18dede1e49183a429)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <github-actions@github.com>
Copilot AI review requested due to automatic review settings December 9, 2025 01:02
@benceruleanlu benceruleanlu requested a review from a team as a code owner December 9, 2025 01:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/restore-cancel-topmenu-1.33

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/09/2025, 02:22:39 AM UTC

📈 Summary

  • Total Tests: 494
  • Passed: 480 ✅
  • Failed: 0
  • Flaky: 5 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 471 / ❌ 0 / ⚠️ 5 / ⏭️ 9
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/09/2025, 02:13:29 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports commit 259e956 to the core/1.33 branch, restoring the cancel button functionality in the top menu section. The change adds a cancel/interrupt button to the action bar that allows users to cancel currently running jobs.

  • Adds a new cancel button with proper disabled state based on execution status
  • Integrates with the existing command system using Comfy.Interrupt
  • Includes proper i18n support and accessibility attributes

@benceruleanlu benceruleanlu added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 9, 2025
@christian-byrne christian-byrne changed the title Backport: Restore Cancel Button to core/1.33 [backport core/1.33] Restore Cancel Button Dec 9, 2025
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 9, 2025
@christian-byrne christian-byrne merged commit baf8fb9 into core/1.33 Dec 9, 2025
29 checks passed
@christian-byrne christian-byrne deleted the backport/restore-cancel-topmenu-1.33 branch December 9, 2025 02:29
@christian-byrne christian-byrne mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benceruleanlu @christian-byrne