Skip to content

Devex: Linter updates #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 14 commits into from
Dec 10, 2025
Merged

Devex: Linter updates #7309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4d25210
lint: Turn on some more oxlint plugins
DrJKL Dec 10, 2025
46a676b
deps: Update lint and prettier deps
DrJKL Dec 10, 2025
2c83dd8
format: Format files
DrJKL Dec 10, 2025
6f5914d
lint: turn on no-undef-properties
DrJKL Dec 10, 2025
e7c2fe2
lint: no-useless-mustaches
DrJKL Dec 10, 2025
a774d71
lint: no-useless-v-bind and fixes
DrJKL Dec 10, 2025
14c6e26
lint: no-unused-refs
DrJKL Dec 10, 2025
fafb7e3
lint: no-unused-emit-declarations
DrJKL Dec 10, 2025
711b810
lint: no-use-v-else-with-v-for
DrJKL Dec 10, 2025
755a3b8
lint: one-component-per-file
DrJKL Dec 10, 2025
24a098d
lint: Add patch for single use of radial-gradient
DrJKL Dec 10, 2025
34f8414
[automated] Apply ESLint and Prettier fixes
actions-user Dec 10, 2025
f17f478
Update eslint.config.ts
DrJKL Dec 10, 2025
0681256
lint: Remove disabling of two rules not yet turned on in oxlint
DrJKL Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,37 @@
"src/types/generatedManagerTypes.ts",
"src/types/vue-shim.d.ts"
],
"plugins": [
"eslint",
"import",
"oxc",
"typescript",
"unicorn",
"vitest",
"vue"
],
"rules": {
"no-async-promise-executor": "off",
"no-control-regex": "off",
"no-eval": "off",
"no-redeclare": "error",
"no-self-assign": "allow",
"no-unused-expressions": "off",
"no-unused-private-class-members": "off",
"no-useless-rename": "off",
"import/default": "error",
"import/export": "error",
"import/namespace": "error",
"import/no-duplicates": "error",
"import/consistent-type-specifier-style": [
"error",
"prefer-top-level"
],
"jest/expect-expect": "off",
"jest/no-conditional-expect": "off",
"jest/no-disabled-tests": "off",
"jest/no-standalone-expect": "off",
"jest/valid-title": "off",
"typescript/no-this-alias": "off",
"typescript/no-unnecessary-parameter-property-assignment": "off",
"typescript/no-unsafe-declaration-merging": "off",
Expand All @@ -39,6 +62,7 @@
"typescript/restrict-template-expressions": "off",
"typescript/unbound-method": "off",
"typescript/no-floating-promises": "error",
"vue/no-import-compiler-macros": "error"
"vue/no-import-compiler-macros": "error",
"vue/no-dupe-keys": "error"
}
}
8 changes: 4 additions & 4 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"declaration-property-value-no-unknown": [
true,
{
"typesSyntax": {
"radial-gradient()": "| <any-value>"
Copy link
Contributor

@christian-byrne christian-byrne Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do to the plugin exactly?

Copy link
Contributor Author

@DrJKL DrJKL Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix for an issue in the newer stylelint. (Not this one, but related)

Copy link
Contributor Author

@DrJKL DrJKL Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The offending site is here

Copy link
Contributor

@christian-byrne christian-byrne Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

},
"ignoreProperties": {
"speak": ["none"],
"app-region": ["drag", "no-drag"],
Expand Down Expand Up @@ -56,10 +59,7 @@
"function-no-unknown": [
true,
{
"ignoreFunctions": [
"theme",
"v-bind"
]
"ignoreFunctions": ["theme", "v-bind"]
}
]
},
Expand Down
21 changes: 14 additions & 7 deletions eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ export default defineConfig([
allowInterfaces: 'always'
}
],
'import-x/consistent-type-specifier-style': ['error', 'prefer-top-level'],
'import-x/no-useless-path-segments': 'error',
'import-x/no-relative-packages': 'error',
'unused-imports/no-unused-imports': 'error',
Expand All @@ -146,14 +145,13 @@ export default defineConfig([
'vue/multi-word-component-names': 'off', // TODO: fix
'vue/no-template-shadow': 'off', // TODO: fix
'vue/match-component-import-name': 'error',
/* Toggle on to do additional until we can clean up existing violations.
'vue/no-unused-emit-declarations': 'error',
'vue/no-unused-properties': 'error',
'vue/no-unused-refs': 'error',
'vue/no-use-v-else-with-v-for': 'error',
'vue/no-useless-mustaches': 'error',
'vue/no-useless-v-bind': 'error',
// */
'vue/one-component-per-file': 'off', // TODO: fix
'vue/no-unused-emit-declarations': 'error',
'vue/no-use-v-else-with-v-for': 'error',
'vue/one-component-per-file': 'error',
'vue/require-default-prop': 'off', // TODO: fix -- this one is very worthwhile
// Restrict deprecated PrimeVue components
'no-restricted-imports': [
Expand Down Expand Up @@ -297,5 +295,14 @@ export default defineConfig([
// Turn off ESLint rules that are already handled by oxlint
...oxlint.buildFromOxlintConfigFile(
path.resolve(import.meta.dirname, '.oxlintrc.json')
)
),
{
rules: {
'import-x/default': 'off',
'import-x/export': 'off',
'import-x/namespace': 'off',
'import-x/no-duplicates': 'off',
'import-x/consistent-type-specifier-style': 'off'
}
}
])
Loading