-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial download-folder-selector interface #890
Merged
Merged
Changes from 6 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
806cad6
initial download-folder-selector interface
mcmonkey4eva e712e8e
use primevue select
mcmonkey4eva 1e6a66c
add a folder select visibility checkbox
mcmonkey4eva 06f03cc
slightly reduce indirection
mcmonkey4eva 2b0d412
Merge branch 'main' into downloader-folder-selection
mcmonkey4eva a9b64e9
fix up select box updating
mcmonkey4eva ac9fa5d
Merge remote-tracking branch 'origin/dev1.3' into downloader-folder-s…
mcmonkey4eva a6ed52f
revert bad upstream changes
mcmonkey4eva 36ddd7c
cleanup
mcmonkey4eva a701832
allow localhost sourced models in ui side
mcmonkey4eva 0cc48d3
add screenshot expectations to test
mcmonkey4eva 980540c
Merge branch 'dev1.3' into downloader-folder-selection
mcmonkey4eva be0fab9
Update test expectations [skip ci]
invalid-email-address 557f81a
add testing of folder select
mcmonkey4eva e1e8c88
fix test
mcmonkey4eva e84366f
don't exclude folder selector when there's only 1
mcmonkey4eva ae3f927
oo - fix checkbox
mcmonkey4eva 6190727
Update test expectations [skip ci]
invalid-email-address 6f9b5bf
testing - don't expect screenshots :(
mcmonkey4eva 8b7da47
experimental new test code
mcmonkey4eva 5456fa3
toHaveClass is silly
mcmonkey4eva 500c9b1
Merge branch 'dev1.3' into downloader-folder-selection
mcmonkey4eva 3c96790
Merge branch 'dev1.3' into downloader-folder-selection
mcmonkey4eva 048e711
add // comments documenting intent of allowedSources
mcmonkey4eva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this becomes hard coded again? We do want to expose this configurability to cloud deployment platforms to download from custom endpoints.