-
Notifications
You must be signed in to change notification settings - Fork 440
fix 'unsaved' value when closing workflows #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
huchenlei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a playwright test to verify the fix works?
|
I also noticed workflows are set as unsaved, when we drag a PNG or JSON file. Does this PR address this ? ( I was about to open an issue ) Most of the time, my "unsaved workflows" are just a PNG or JSON file I dragged in, to check the workflow. This way, I can have 10 unsaved workflows or more. |
|
Well that genuinely is an unsaved workflow -- quicker ways to clear out random workflows (eg shift+click close to bypass unsaved prompt) would be a valid feature request to file |
|
I don't really know what to do here other than mark the untested new test as skip pending the relevant 1.3 core test failures being fixed first |
|
actually considering that's becoming a merge conflict issue and it's entirely untested anyway, I'm going to remove it for now, and recommend (cc @huchenlei ) that we merge as-is with just the fix and add a test later once the tests in general are able to properly test this section of code. (Noting that this PR is a literal 1-line change minor bugfix and it has been sat waiting for 2 weeks and encountering merge conflicts due to the testing issues) |

for #735
Linked issue describes the problem well. I replicated it locally, tested, found it comes down to just this variable not getting unset where other variables are unset at, so I unset it there. After this update, reopening a saved workflow that you opened previously does correctly treat the workflow as initially being not unsaved.