Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Upgrade typescript-eslint to v8 #646

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[chore] Upgrade typescript-eslint to v8 #646

merged 1 commit into from
Jan 16, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 16, 2025

Get rid of eslint warning. The plugin deps were added in e8617b3 (5months ago), while the eslint itself is upgraded recently #536 (1months ago).

Before:

D:\desktop [main ≡]> yarn
➤ YN0000: · Yarn 4.5.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ eslint is listed by your project with version 9.17.0 (p3aad5), which doesn't satisfy what @typescript-eslint/eslint-plugin and other dependencies request (^8.57.0).
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 684ms
➤ YN0000: ┌ Link step
➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed
➤ YN0000: └ Completed in 2s 96ms
➤ YN0000: · Done with warnings in 3s 31ms

After:

D:\desktop [main ≡ +0 ~2 -0 !]> yarn
➤ YN0000: · Yarn 4.5.0
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed
➤ YN0000: ┌ Post-resolution validation
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed in 0s 652ms
➤ YN0000: ┌ Link step
➤ YN0008: │ @comfyorg/comfyui-electron@workspace:. must be rebuilt because its dependency tree changed
➤ YN0000: └ Completed in 1s 839ms
➤ YN0000: · Done with warnings in 2s 737ms

@huchenlei huchenlei requested a review from a team as a code owner January 16, 2025 22:33
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@eslint-community/eslint-utils@4.4.1 🔁 npm/@eslint-community/eslint-utils@4.4.0 None 0 378 kB eslint-community-bot
npm/@eslint-community/regexpp@4.12.1 🔁 npm/@eslint-community/regexpp@4.11.1 None 0 473 kB eslint-community-bot
npm/@typescript-eslint/eslint-plugin@8.20.0 🔁 npm/@typescript-eslint/eslint-plugin@5.62.0 None 0 2.82 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@8.20.0 🔁 npm/@typescript-eslint/parser@5.62.0 None 0 18.9 kB bradzacher, jameshenry
npm/@typescript-eslint/scope-manager@8.20.0 🔁 npm/@typescript-eslint/scope-manager@5.62.0 None 0 626 kB bradzacher, jameshenry
npm/@typescript-eslint/type-utils@8.20.0 🔁 npm/@typescript-eslint/type-utils@5.62.0 None 0 127 kB bradzacher, jameshenry
npm/@typescript-eslint/types@8.20.0 🔁 npm/@typescript-eslint/types@5.62.0 None 0 174 kB bradzacher, jameshenry
npm/@typescript-eslint/typescript-estree@8.20.0 🔁 npm/@typescript-eslint/typescript-estree@5.62.0 None 0 594 kB bradzacher, jameshenry
npm/@typescript-eslint/utils@8.20.0 🔁 npm/@typescript-eslint/utils@5.62.0 None 0 288 kB bradzacher, jameshenry
npm/@typescript-eslint/visitor-keys@8.20.0 🔁 npm/@typescript-eslint/visitor-keys@5.62.0 None 0 19.6 kB bradzacher, jameshenry
npm/eslint-scope@8.2.0 🔁 npm/eslint-scope@5.1.1 None 0 152 kB eslintbot
npm/is-arrayish@0.2.1 None 0 4.05 kB qix
npm/spdx-correct@3.2.0 None 0 23.4 kB kemitchell
npm/spdx-expression-parse@3.0.1 None 0 11.8 kB kemitchell
npm/ts-api-utils@2.0.0 None 0 353 kB joshuakgoldberg

🚮 Removed packages: npm/eslint-visitor-keys@3.4.3, npm/estraverse@4.3.0, npm/natural-compare-lite@1.4.0, npm/tsutils@3.21.0

View full report↗︎

@huchenlei huchenlei merged commit 561c434 into main Jan 16, 2025
6 checks passed
@huchenlei huchenlei deleted the fix_eslint_dep branch January 16, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant