Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NodeSlot #476

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Implement NodeSlot #476

merged 2 commits into from
Feb 7, 2025

Conversation

huchenlei
Copy link
Member

This PR implements the NodeInputSlot and NodeOutputSlot classes.

Codesearch shows that the only usage of direct push to LGraphNode.inputs/outputs is in rgthree.

Maybe the conversion is not necessary?

@huchenlei huchenlei requested a review from webfiltered February 7, 2025 20:13
@huchenlei
Copy link
Member Author

Can also use toClass implemented in #466 after that PR landed.

@webfiltered
Copy link
Contributor

Found some more instances by checking for splice, and also sifting through some much less specific searches. I think there'll be breakage without some kind of handling.

@huchenlei
Copy link
Member Author

Found some more instances by checking for splice, and also sifting through some much less specific searches. I think there'll be breakage without some kind of handling.

Sure, let's just do on-spot conversion for now.

@huchenlei huchenlei merged commit 608b5f8 into master Feb 7, 2025
4 checks passed
@huchenlei huchenlei deleted the node_slot branch February 7, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfiltered webfiltered Awaiting requested review from webfiltered

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huchenlei @webfiltered