Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _.pick to simplify serialization #763

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Implement _.pick to simplify serialization #763

merged 1 commit into from
Mar 12, 2025

Conversation

huchenlei
Copy link
Member

Simplify the serialization code, so that we only write each prop once.

@huchenlei huchenlei merged commit 7746511 into master Mar 12, 2025
4 checks passed
@huchenlei huchenlei deleted the pick_props branch March 12, 2025 20:08
webfiltered added a commit that referenced this pull request Mar 12, 2025
webfiltered added a commit that referenced this pull request Mar 22, 2025
webfiltered added a commit that referenced this pull request Mar 22, 2025
Reason: Performance

- 40x slower slot serialisation using randomised data
- Overall 2-3x slower `graph.serialize()` on a 600 node graph

This reverts commit 7746511.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant