Dev #13
Merged
Dev #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added tags, install_params and custom_install_url to application class
Previously, the condition depended also on the sequence number.
This was supposed to handle the wrap around case. In reality,
it depends on what LHS and RHS are, and flipping the LHS and RHS
breaks the ordering.
Recall that LHS has lower priority, i.e. should appear behind, RHS if
LHS.seq > RHS.seq || LHS.timestamp > RHS.timestamp
The timestamp is only taken into account if LHS.seq <= RHS.seq.
For example, in case of LHS.seq = 1 < 65530 = RHS.seq, the
timestamp will be taken into account, which could place
LHS (1) after RHS (65530). However, if we flip the sides, so that
LHS.seq = 65530 and RHS.seq = 1, then LHS (65530) is immediately
placed after RHS (1), without considering the timestamp, which is
incorrect behavior.
The consequence is that the ordering in the payload queue is
incorrect. For instance, seq=65530 can appear after seq=65531,
and the loop has to run through all sequence numbers from 65531,
to 65535, to 1, back to 65530. As we approach the wrap-around
case, we tend to hang long in the voice courier thread.
Depend `discord_voice_client::voice_payload` priority only on timestamps.
updated docs
removed deprecated exclamation mark from guild_member::get_mention
implemented channel::get_icon_url & small doc improvements of slashcommand.h and some intent fixes
… connect() hanging gracefully
…unctionality. use edotor.net to build them interactively
* The new DNS feature uses unique_lock with shared_mutex * This requires mutex include in gcc 11+, clang 12.0.1+
🐛 Fix DNS mutex include
fix: delete_webhook_with_token should send DELETE
docs: some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.