d #3
Merged
d #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/dpp/application.cpp
added application icon getters
If the voice courier thread waits because of no voice data, it can hang forever in the destructor because the thread is never signaled to unblock (unless woken up by a spurious wake). This change adds the signaling in the destructor to unblock a waiting courier thread.
Fix potential hang in discord_voice_client destructor.
The break condition of the voice courier thread is incorrect. It is checking the client user ID to parking lot map size, but it should be checking whether there are any payloads to deliver.
Fix discord_voice_client hanging in destructor, again.
The condition variable condition always succeeds, so it has no benefit in improving energy consumption. Removing the condition because we actually need to iterate over our containers (or introduce extra states, which I am not a big fan of) to find out whether there are payloads to deliver.
Improve discord_voice_client energy.
…as its own parameter type
Commandserver
pushed a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.