#530, #529, #501, #494, #458 - Initial commit #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilotte
added
the
for 1.7 release
johnbeve
reviewed
Nov 3, 2024
There was a problem hiding this comment.
Back of the envelope calculations (not including MRO):
- There are 43 skos:scopeNote annotations in the merged file and 62 across the modules (something is amiss)
- There are 1569 skos:definition annotations in both the merged and across all modules, respectively (but see next section for reason to think merged should be 1568)
- There are 74 skos:example annotations in the merged but 73 across the modules (this is OK if remove the annotation declaration for example_of_usage identified below)
- There are 351 skos:altLabel annotations in the merged but 356 across the modules
The following should be removed:
-
http://www.ontologyrepository.com/CommonCoreOntologies/example_of_usage
-
http://www.ontologyrepository.com/CommonCoreOntologies/definition
FYSA In the merged and modal relations files:
- BFO definitions are using http://www.w3.org/2004/02/skos/core#definition while cco definitions are using http://www.w3.org/2004/02/skos/core#
- BFO alternative labels are using http://www.w3.org/2004/02/skos/core#altLabel while cco alt labels are using http://www.w3.org/2004/02/skos/core#
- BFO notes are using http://www.w3.org/2004/02/skos/core#scopeNote while cco notes are using http://www.w3.org/2004/02/skos/core#
- BFO examples are using http://www.w3.org/2004/02/skos/core#example while cco exampls are using http://www.w3.org/2004/02/skos/core#
There was a problem hiding this comment.
@johnbeve Good catch. I think this file is regenerated anyway. I'll do that in next commit.
There was a problem hiding this comment.
@neilotte Didn't realize you could see, I've been updating this comment so there might be a bit more to check (done with it now!)
There was a problem hiding this comment.
@johnbeve I've updated the merged file, but I believe the dev team is automating generation of the modal file so I won't touch it further here (@mark-jensen or @cameronmore are welcome to though, here or on a subsequent MR).
There was a problem hiding this comment.
@mark-jensen @johnbeve Updated two sparql queries that used cco:definition as well.
This commit adds declarations for those new properties adopted in 1.7.
At Mark's request, I've removed declarations of skos, rdfs, and dcterms annotation properties from the extended relations ontology. We'll discuss this in 2.1.
Updated the 'is curated in' annotation for 'is interest of' and its inverse to reflect that these relations are curated in AgentOntology.ttl and not ERO.
Ported over @cameronmore 's changes to Agent axiom and Agent Capability from other branch to avoid merge conflicts pursuant 1.7 release,
This was
linked to
issues
Nov 3, 2024
Updating two missed cco:definition annotations to skos:definition
To conform to 1.7
Updated to align with 1.7
mark-jensen
approved these changes
Nov 3, 2024
mark-jensen
deleted the
#530-#529-#501-#494-#458--annotation-changes-for-1.7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.