Skip to content

Conversation

@bbrands02
Copy link
Collaborator

No description provided.

@github-actions
Copy link

👋 @bbrands02
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible. In the meanwhile make sure your PR checks the following boxes

  • Is based on an issue
  • Has been locally tested
  • Has been tested with the admin UI
  • Has been discussed with the development team in an open channel

@github-actions
Copy link

Your image ghcr.io/commongateway/wooservice-php:prod critical: 0 high: 0 medium: 1 low: 0 unspecified: 2
Current base image php:8.2-fpm-alpine critical: 0 high: 0 medium: 1 low: 0 unspecified: 1
Updated base image php:8.3.2-fpm-alpine critical: 0 high: 1 medium: 1 low: 0 unspecified: 1

@github-actions
Copy link

github-actions bot commented Apr 10, 2024

🔍 Vulnerabilities of ghcr.io/commongateway/wooservice-php:prod

📦 Image Reference ghcr.io/commongateway/wooservice-php:prod
digestsha256:3c9dea73b2edfd35952fd664a69fd5aa70e72e2464f34b6ecb641c42e192713d
vulnerabilitiescritical: 0 high: 0 medium: 1 low: 0 unspecified: 2
size247 MB
packages312
📦 Base Image php:8.2-fpm-alpine
also known as
  • 8.2-fpm-alpine3.19
  • 8.2.17-fpm-alpine
  • 8.2.17-fpm-alpine3.19
digestsha256:c5d9ca92dd6998511c65f223359eec2b0eb1cef311bed2aa2c3778657de8ab28
vulnerabilitiescritical: 0 high: 0 medium: 1 low: 0 unspecified: 1
critical: 0 high: 0 medium: 1 low: 0 c-ares 1.24.0-r1 (apk)

pkg:apk/alpine/c-ares@1.24.0-r1?os_name=alpine&os_version=3.19

medium : CVE--2024--25629

Affected range<1.27.0-r0
Fixed version1.27.0-r0
EPSS Score0.00043
EPSS Percentile0.07762
Description
critical: 0 high: 0 medium: 0 low: 0 unspecified: 1dompdf/dompdf 2.0.4 (composer)

pkg:composer/dompdf/dompdf@2.0.4

unspecified : GMS--2024--338 OWASP Top Ten 2017 Category A9 - Using Components with Known Vulnerabilities

Affected range<=2.0.4
Fixed versionNot Fixed
Description

Improper Neutralization in dompdf/dompdf.

critical: 0 high: 0 medium: 0 low: 0 unspecified: 1openssl 3.1.4-r5 (apk)

pkg:apk/alpine/openssl@3.1.4-r5?os_name=alpine&os_version=3.19

unspecified : CVE--2024--2511

Affected range<3.1.4-r6
Fixed version3.1.4-r6
EPSS Score0.00045
EPSS Percentile0.13571
Description

Comment on lines 232 to 238
$tempFilePath = tempnam(sys_get_temp_dir(), 'docx');
if ($tempFilePath === false) {
$this->logger->error('Failed to create a temporary file '.$file->getName());
$this->style && $this->style->error('Failed to create a temporary file '.$file->getName());
}

file_put_contents($tempFilePath, $base64Decoded);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could consider moving this to a separate function, seems to me that this will happen more often.

$text = null;
}
break;
case 'application/vnd.openxmlformats-officedocument.wordprocessingml.document':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favor of putting everything in a case in a separate function, although I could imagine only putting the contents of try in a separate function.

@bbrands02 bbrands02 force-pushed the feature/WOO-49/extract-text-from-docx branch from 8514fdb to b683fd7 Compare April 10, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants