forked from BlockScience/proposal-inverter
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove broker and owner class and use wallet #7
Open
patriacaelum
wants to merge
89
commits into
CommonsBuild:main
Choose a base branch
from
patriacaelum:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allet Remove broker class and use wallet
…ow deploying without releasing funds
Added payer contributions and changed minimum start conditions to all…
…anisms themselves
This was referenced Oct 27, 2021
…d NoVote and fix unit tests
Process for whitelisting brokers
Add files via upload
…sation Matrix factorisation visualisation
…sation Updated Matrix Factorisation Visualisation
…sation rm piror iterations (cleaned) + added labelling
24 accomodate multiple tokens
…llation 34 add broker stake to cancellation
Merge remote-tracking branch 'origin' into matrix-factorisation-visua…
Supplementary proposal data
…to-more-actions 25 add matrix factorization to more actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for using the
ProposalInverter
for cadCAD simulations, agents are able to act as owners, payers, and brokers and are not limited to one role. Thus the following changes have been made:Broker
andOwner
class have been merged into a singleWallet
classProposalInverter
uses theWallet
class instead of theBroker
classProposalInverter.cancel()
method now checks for the correct owner's public key. This is not meant to be extremely secure, but we could change this to use the private key to ensure only the owner can cancel their own proposal