Skip to content

Conversation

@Odonno
Copy link
Contributor

@Odonno Odonno commented Jan 14, 2026

Fixes #974

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@Odonno
Copy link
Contributor Author

Odonno commented Jan 14, 2026

For context, CollectionDefinition only seem to work with child class and not the base class.

@aaronpowell
Copy link
Member

Is that why they haven't been shutting down properly?!

@Odonno
Copy link
Contributor Author

Odonno commented Jan 15, 2026

Yes, I reproduced the issue locally and this code fixes it.

@aaronpowell aaronpowell merged commit 67afcca into CommunityToolkit:main Jan 16, 2026
118 checks passed
@Odonno Odonno deleted the fix/surrealdb-tests branch January 16, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SurrealDB test stability

2 participants