Fix Solr docker image name for Azure Container Registry caching #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
aaronpowell
September 4, 2025 02:11
aaronpowell
approved these changes
Sep 4, 2025
Minimum allowed line rate is |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build failure in the Solr integration by updating the Docker image name to be compatible with Azure Container Registry caching. The change updates the image reference from "solr" to "library/solr" to follow the explicit namespace pattern required for official Docker images when using Azure Container Registry caching.
Key changes:
- Updated the Docker image name constant to include the explicit
library/namespace prefix - Aligned the Solr integration with the established pattern used by other official Docker image integrations
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was failing due to an incorrect docker image name for the Solr integration that doesn't work with Azure Container Registry caching.
Problem
The Solr integration was using
"solr"as the image name, but for Azure Container Registry caching to work properly, official Docker images need to specify the explicitlibrary/namespace.Solution
Updated
SolrContainerImageTags.csto change the image name from"solr"to"library/solr".This follows the same pattern already established by other integrations that use official Docker images, such as Adminer which uses
"library/adminer". Images with organization namespaces (likeminio/minio,eventstore/eventstore) don't need this prefix since they already have an explicit namespace.Changes
Imageconstant inSolrContainerImageTags.csfrom"solr"to"library/solr"This is a minimal change that addresses the root cause of the build failures without affecting any functionality.
Fixes #832.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.comdotnet build src/CommunityToolkit.Aspire.Hosting.Solr/CommunityToolkit.Aspire.Hosting.Solr.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.