Remove npm functionality moved to Aspire 13 #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove AddViteApp and WithNpmPackageInstaller from CT
Remove npm functionality moved to Aspire 13
Oct 27, 2025
Copilot finished work on behalf of
aaronpowell
October 27, 2025 05:09
aaronpowell
approved these changes
Oct 27, 2025
Minimum allowed line rate is |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
eerhardt
reviewed
Oct 31, 2025
| /// Indicates that apps in this monorepo workspace should be executed via a package manager wrapper (e.g., npx, yarn, pnpm). | ||
| /// </summary> | ||
| /// <param name="packageManager">The name of the JavaScript package manager (e.g., "npm", "yarn", "pnpm").</param> | ||
| public sealed class JavaScriptPackageManagerExecutionAnnotation(string packageManager) : IResourceAnnotation |
There was a problem hiding this comment.
You should be able to use https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/JavaScriptPackageManagerAnnotation.cs now with the latest builds.
eerhardt
reviewed
Oct 31, 2025
|
|
||
| ```csharp | ||
| builder.AddYarnApp("yarn-demo") | ||
| builder.AddYarnApp("yarn-demo", "../yarn-demo") |
There was a problem hiding this comment.
Would it be possible to build AddYarnApp on top of AddJavaScriptApp?
There was a problem hiding this comment.
that's just legacy docs I have to clean up still, it's meant to be replaced by AddJavaScriptApp().WithYarn()
aaronpowell
deleted the
copilot/remove-addviteapp-and-withnpmpackageinstaller
branch
aaronpowell
added a commit
that referenced
this pull request
Nov 6, 2025
* baseline branch for the next major release * Updating nightly * Remove deprecated IDistributedApplicationLifecycleHook interface (#915) * Initial plan * Replace IDistributedApplicationLifecycleHook with event-based patterns Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Add tests for installer resources and update Dapr tests Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Refactor Dapr to use IDistributedApplicationEventingSubscriber Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Fixing build issue * Updating the endpoint port * Disabling some tests so we can move forward in other parts of the Aspire 13 update --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com> * Adjusting the version of keycloak * Updating aspire nightly * New nightly * Remove npm functionality moved to Aspire 13 (#928) * Initial plan * Remove AddViteApp and npm-specific functionality (moved to Aspire 13) Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update comments and tests to reflect npm removal Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Update MONOREPO.md to remove npm references Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Adding missing types * Bad copilot code * Fixing missing namespace * Handling port forwarding * removing more stuff that has been migrated to aspire core * Reworking how package installing is handled * daily update * Adding back the annotation that is no longer moving to core * Forgot to install packages * adding a bunch more annotations to provide enough metadata * Removing old demo apps * Disabling python tests * Removing a testing change * Updating to the latest nightly and dealing with type name changes * Removing type that was can repurpose from aspire core * breaking the tests down so they are easier to read * Removing legacy docs * Fixing failing tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com> * Fixing failing test * Remove deprecated EventStore integrations (#946) * Initial plan * Remove EventStore integrations and all associated files Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Remove EventStore project references from solution file Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com> Co-authored-by: Fredi Machado <fredisoft@gmail.com> * Creating a new agent for generating hosting integrations * Creating a new agent for generating client integrations * Expanded the hosting agent a bit * Removing the legacy approach to checking resource health and updated the last usages of it * Bumping go and removing pnpm setup * maybe we need an explicit health check * Using the new JavaScriptAppResource so we can leverage the new methods on inspector Getting rid of some custom code but making it so we run from local by default * Disabling tests on Windows due to modelcontextprotocol/inspector#893 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> Co-authored-by: Fredi Machado <fredisoft@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm support (
AddNpmApp,AddViteApp,WithNpmPackageInstallation) is moving to Aspire.Hosting.NodeJS in Aspire 13 (dotnet/aspire#12283). Yarn and pnpm remain Community Toolkit exclusive.Removed
AddViteApp()- Vite convenience wrapperWithNpmPackageInstallation()- npm package installer for Node appsWithNpmPackageInstaller()- npm installer for Nx/Turborepo monoreposNpmInstallerResource- npm installer resource typeJavaScriptPackageManagerAnnotation/JavaScriptPackageInstallerAnnotation- now provided by AspireRetained (yarn/pnpm)
AddYarnApp()/AddPnpmApp()WithYarnPackageInstallation()/WithPnpmPackageInstallation()WithYarnPackageInstaller()/WithPnpmPackageInstaller()for monoreposYarnInstallerResource/PnpmInstallerResourceMigration
Before:
After (use Aspire.Hosting.NodeJS):
Notes
WithMappedEndpointPort()preserves npm annotation compatibility for Aspire interopImpact: -513 lines (13 files) | npm functionality → Aspire | yarn/pnpm → CT exclusive
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.comdotnet build src/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
AddViteAppandWithNpmPackageInstaller#924💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.