Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker doesn't return the right results with MockProviderBehavior #24

Closed
michael-hawker opened this issue Nov 1, 2019 · 2 comments · Fixed by #25
Closed

PeoplePicker doesn't return the right results with MockProviderBehavior #24

michael-hawker opened this issue Nov 1, 2019 · 2 comments · Fixed by #25
Assignees
Labels
bug 🐛 Something isn't working Completed 🔥
Milestone

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Nov 1, 2019

Describe the bug

The MockProvider always seems to return the same search results regardless of the search query.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Run sample
  2. Type in 'Alex'

Expected behavior

Expect to see Alex Wilber at top, but instead see other random list containing Isaiah.

Screenshots

image

Works in Graph Explorer:
image

Works fine in Live Service too:
image

Additional context

The service is working fine as seen through Graph Explorer, confirmed with network inspection that query parameters are getting mangled by MockProvider.

@ghost ghost added the needs triage 🔍 label Nov 1, 2019
@michael-hawker michael-hawker self-assigned this Nov 1, 2019
@michael-hawker michael-hawker added bug 🐛 Something isn't working and removed needs triage 🔍 labels Nov 1, 2019
@michael-hawker michael-hawker pinned this issue Nov 1, 2019
@michael-hawker
Copy link
Member Author

I've confirmed this is explicitly an issue with our MockProvider. It doesn't appear to be appending the query parameters for the search correctly.

@michael-hawker
Copy link
Member Author

This appears to be happening somewhere in the construction of the base HttpRequest done by the Graph SDK, opened an issue there to try and get some more info based on the observations I've seen over the network between the web and .NET SDK differences.

michael-hawker added a commit that referenced this issue Nov 6, 2019
@ghost ghost added the In-PR 🚀 label Nov 6, 2019
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Nov 7, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2019
@michael-hawker michael-hawker unpinned this issue Aug 6, 2020
@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 Something isn't working Completed 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants