Create a shared project for Unit Tests heads to leverage #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talked to @jeromelaban after digging into binlogs, he thinks it may be this issue I'm hitting: unoplatform/uno#5007 (comment) Going to try the suggested property first, then was going to try and add a dummy page to the shared project, as that's the only other difference I could see in the binlog between the working sample app project and the not working test project. |
…p is share App.xaml/App.xaml.cs WinUI 3 working in All solution, UWP builds but is not connecting?
michael-hawker
force-pushed
the
llama/unittest-sharedproject
branch
from
83cd2cf to
ff0eccf
Compare
|
With the workaround from the Uno issue, the UWP Unit Test app in the all solution is building now. But the test harness in VS seems to be timing out or having issues communicating with it now...? It doesn't seem to want to let me debug the app either, so not sure how to get more info just yet. |
24 tasks
…TestBase, add simple automation GridSplitter test
|
Things coming together and looking good so far in the CI!
Might call this good for this PR then for now, and the first half of #124. Don't think we'll need more than this at the moment and the rest can be done via the new shared project? |
michael-hawker
changed the title
6 tasks
michael-hawker
added a commit
that referenced
this pull request
Jun 7, 2022
* Test projects to reference the project with the experiment code Duplicated change with #126 * Update the displayed template name * Increase the namespaces referenced in the example test file This list is based on what's most commonly used in existing toolkit tests. * Make internal classes visible to all test projects For #127 * set type to "solution" as per dotnet/templating#4771 * Add more info about a created solution for a new experiment For #127 * Don't include the labexp template in VS it doesn't work there * Update template/README.md Co-authored-by: Arlo <arlo.godfrey@outlook.com> * Update template/README.md Co-authored-by: Arlo <arlo.godfrey@outlook.com> * Update template/README.md Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com> * Update template/README.md Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com> * Update template/README.md Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com> * Update template/README.md Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com> * Revert "Test projects to reference the project with the experiment code" This reverts commit 5dccf8a. * Update example test to reference the code being developed & to use a naming convention better matched to the wider toolkit convention * increase the number of namespaces included by default in the generated code This is to reduce the effort required to begin work on an experiment. * add placeholders and TODO notes for including links to relevant discussion & issue * update new experiment doc to reflect changes in solution structure Co-authored-by: Arlo <arlo.godfrey@outlook.com> Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…olkit#126) * Create a shared project for Unit Tests heads to leverage, initial step is share App.xaml/App.xaml.cs WinUI 3 working in All solution, UWP builds but is not connecting? * Test adding Newtonsoft Reference for UWP Test Fix? * Move workarounds for UWP Unit Tests to props file vs. csproj * Test if reshuffle of propsfiles works or not * Apply shared unit test project to ProjectTemplate * Apply shared Unit Test project to Experiment Projects * Add Library Projects to Unit Test Projects, Bring in initial VisualUITestBase, add simple automation GridSplitter test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial step for #124 to share App.xaml/App.xaml.cs
This covers the majority of the sub-steps of the 2nd bullet (at least in terms of the all-up solution, need to apply to experiments)
WinUI 3 working in All solution
However UWP is not with this error:
It's trying to use the full path as a relative path for some bizarre reason. I've triple-checked that this is the exact same layout/setup we're using for the Sample app heads (which seem to work). So not sure why the XAML Compiler is going wrong here.
Wanted to check if the CI did the same thing.