Fixed sample source not displaying on Wasm, WPF and GTK #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
michael-hawker
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Looks good, though looks like #82 broke running the all-samples in codespaces.
michael-hawker
added
Uno
20 tasks
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…lkit#88) * Fixed sample source not displaying on Wasm, WPF and GTK * Removed irrelevant note * Remove unused variable
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…1/titlebar-improvements Gallery design improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where XAML/C# source for samples weren't properly bundled as part of the app, and couldn't be displayed alongside the sample itself.
This fix has been tested for WebAssembly, WPF, GTK, UWP and WinAppSDK in debug mode. The fix does not work for Android, but could be made to work in the future with this workaround from Uno, or if fixed from Uno's side.
Closes #37