[BUG] Popup v2 - App Crash with secondary Window

[hwsmo]

Is there an existing issue for this?

• I have searched the existing issues

Did you read the "Reporting a bug" section on Contributing file?

• I have read the "Reporting a bug" section on Contributing file: https://github.com/CommunityToolkit/Maui/blob/main/CONTRIBUTING.md#reporting-a-bug

Current Behavior

The new popup implementation released with version 12.0.0 doesn't work in a Windows Shell app and secondary windows. If I open a page in a new window and then try to open a popup, the app crashes.

The reason is that access to the current shell instance is done with Shell.Current in the PopupPage constructor. However, since the shell window is not active because the secondary window is active, this leads to the following exception:

throw new InvalidOperationException($"Unable to determine the current Shell instance you want to use. Please access Shell via the Windows property on {Application.Current.GetType()}.");

Expected Behavior

The popup will appear in the secondary window.

Steps To Reproduce

The new popup implementation released with version 12.0.0 doesn't work in a Windows Shell app and secondary windows. If I open a page in a new window and then try to open a popup, the app crashes.

Link to public reproduction project repository

Not required as it is very easy to adjust

Environment

- .NET MAUI CommunityToolkit: 12.0.0
- OS: Windows 11
- .NET MAUI: 9.0.70

Anything else?

No response

[VladislavAntonyuk]

In that case, we allow you to use INavigation. It is not necessary to be a Shell.

[dotnet-policy-service]

Hi @@hwsmo! We have added the needs reproduction label to this issue, which indicates that we are unable to take further action until you provide a reproduction sample that we can use to reproduce + fix your bug. In accordance with the Reporting a bug section of our Contributing.md that you confirmed reading before you submitted this Issue, we ask that every Issue author provide a link to an open-source repository containing the reproduction sample app. This issue will be closed automatically in 5 days if we do not receive a reproduction sample from you. Please feel free to re-open this Issue once you have provided a reproduction sample.

[hwsmo]

@VladislavAntonyuk Unfortunately, this is not the solution, because even then an instance of PopUpPage is created:

and the current shell instance is accessed via Shell.Current:

Maui/src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs

Line 46 in 91b5e91

if (Shell.Current is Shell shell)

However, accessing Shell.Current requires that the shell window is "Active":

And that is exactly what leads to the exception and the app crash.

[bijington]

Do we need to call SetPresentationMode on shell when we call it at the end of the constructor on this?

[hwsmo]

@bijington That's right, Shell.SetPresentationMode() is called again at the end. Maybe that would be the solution. Anyway, I would be happy, because my Popup v2 migration is done, but unfortunately this is currently the show stopper.

[dotnet-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 3 days. It will be closed if no further activity occurs within 2 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

[TheCodeTraveler]

Fixed in #2716