-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpeechToText #808 #1127
SpeechToText #808 #1127
Conversation
Thanks Vlad! I made a couple tweaks to this PR:
I test the sample on iOS + MacCatalyst and it works great! I was unable to test on Windows + Android because my current build machine isn't configured properly. |
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.windows.cs
Show resolved
Hide resolved
samples/CommunityToolkit.Maui.Sample/ViewModels/Essentials/SpeechToTextViewModel.cs
Outdated
Show resolved
Hide resolved
Tizen Implementation is added :) |
...ommunityToolkit.Maui.Core/Essentials/SpeechToText/SharedSpeechToTextImplementation.macios.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.macos.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.windows.cs
Outdated
Show resolved
Hide resolved
samples/CommunityToolkit.Maui.Sample/ViewModels/Essentials/SpeechToTextViewModel.cs
Outdated
Show resolved
Hide resolved
...ommunityToolkit.Maui.Core/Essentials/SpeechToText/SharedSpeechToTextImplementation.macios.cs
Show resolved
Hide resolved
src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.ios.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vlad! This is getting really really close!
I confirmed iOS, Android + Windows works.
However, Speech to Text on macOS isn't working for me and I can't quite figure out why. I'll mark this as Request changes
just to ensure we address the macOS issue before accidentally merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vlad!
We're really really close to finishing this.
I confirmed that speech-to-text is working on macOS now, but I found a weird bug that I can't figure out: When I speak into an external microphone on my MacBook Pro, the sample app doesn't detect any sound.
Are you able to duplicate + diagnose this behavior?
In the meantime, I'd say that this API surface is finalized and we're free to start working on the docs! @bijington - do you have availability this week to help with docs for this PR?
@bijington dont worry. I will create a docs pr today. |
@brminnick It works for both microphones: Screen.Recording.2023-05-16.at.20.14.44.mov |
I fixed the Tizen implementation to solve the timing issue between prepare and start listening steps. |
Description of Change
Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information