Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Popup Close call possible NRE. #1197

Closed
wants to merge 3 commits into from

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented May 22, 2023

Description of Change

In a situation where the opening and closing of the Popup depends on external factors, and the Close call occurs before the Show call, there is an NRE here since the Handler is null at that moment

Linked Issues

  • Fixes #

PR Checklist

Additional information

@VladislavAntonyuk VladislavAntonyuk added the do not merge Do not merge this PR label May 22, 2023
@VladislavAntonyuk
Copy link
Collaborator

@HavenDV please create an issue before creating a PR.

@brminnick brminnick added the needs discussion Discuss it on the next Monthly standup label Jun 1, 2023
@brminnick
Copy link
Collaborator

@HavenDV Could you please open an Issue for the bug that you've fixed this PR and include a sample reproduction?

Before we can merge this PR, we need to validate the bug and determine whether this PR fixes its root-cause; we can't do that without a bug report + a reproduction sample.

@HavenDV
Copy link
Contributor Author

HavenDV commented Jun 22, 2023

I don't think it's that important. I think it was just a very specific case, so it's easier to close it. Sorry for wasting time

@HavenDV HavenDV closed this Jun 22, 2023
@HavenDV HavenDV deleted the patch-1 branch June 22, 2023 22:07
@brminnick brminnick removed the needs discussion Discuss it on the next Monthly standup label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants