-
Notifications
You must be signed in to change notification settings - Fork 464
[Housekeeping] Add Benchmarks to GitHub Actions #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
…/CommunityToolkit/Maui into Add-Benchmarks-to-GitHub-Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| name: Build Library | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| VSTEST_TESTHOST_SHUTDOWN_TIMEOUT: 1100 # Fixes "The active test run was aborted. Reason: Test host process crashed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have this issue on new pipeline?
I also curious if this variable is specific to Azure Pipelines or exists in Github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha - I wish I knew the answer to that!
I don't have direct evidence that supports whether we still need it in GitHub Actions or not, but I'd kinda rather keep it just in case since it doesn't introduce any adverse effects to the pipeline and it may save us headaches in the future.
| run: dotnet build ${{ env.PathToCommunityToolkitCoreCsproj }} -c Release -p:PackageVersion=${{ env.NugetPackageVersion }} -p:Version=${{ env.NugetPackageVersion }} | ||
|
|
||
| - name: 'Build CommunityToolkit.Maui' | ||
| run: dotnet build ${{ env.PathToLibrarySolution }} -c Release -p:PackageVersion=${{ env.NugetPackageVersion }} -p:Version=${{ env.NugetPackageVersion }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a library, not solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the Library SLN on purpose to help ensure the pipeline always builds all of the projects.
In the future, a PR may add a new library but forget to update the pipeline. This ensures that the pipeline will still compile the new code until we remember to add it as a separate step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, in that case I still don't see the benefit of building each project individually to build the whole solution later.
I have no strong objections merging the PR, but I still voting keeping it as simple as possible (less code). Once we get the issue with build investigation we can back to the changes.
…/CommunityToolkit/Maui into Add-Benchmarks-to-GitHub-Actions
This PR adds the
Run Benchmarksstep to the GitHub Actions CI/CD Workflow.Additional Information
This PR also adds the following housekeeping updates to the GitHub Actions CI/CD Workflow:
actions/setup-dotnetdotnet-quality: 'ga'Install .NET MAUI Workloaddotnet workload updatefollowingdotnet workload install mauiSet Xcode versionbuild_libraryenv: VSTEST_TESTHOST_SHUTDOWN_TIMEOUT: 1100dotnet packfirst builds the csproj file, however, building each project individually makes it easier for us to quickly identify which project is throwing a compiler error and whether the error is occurring ondotnet buildstep or ondotnet pack