Skip to content

Conversation

@ne0rrmatrix
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix commented Jan 28, 2025

Description of Change

This fixes incorrect XamlRoot being set when application uses modal navigation and opens a popup. The current behavior results in application crashing. This sets the XamlRoot correctly and the app does not crash. Additionally made a cosmetic size change to sizing for large popup as it is too large and covers the whole window in some situations in Multiple Popups Page.

Linked Issues

PR Checklist

Additional information

Currently the windows implementation of Popup has the xaml root set incorrectly. I updated the XamlRoot in the handler for Popup to fix the issue. The linked issue has a CTD when using modal navigation and opening a Popup.

@TheCodeTraveler TheCodeTraveler merged commit 2ac604e into CommunityToolkit:main Jan 29, 2025
16 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Popup is not working on Windows whe opend from a modal

3 participants