Skip to content

Conversation

@phunkeler
Copy link
Contributor

@phunkeler phunkeler commented Feb 16, 2025

Description of Change

[Android] CameraView captures images with the correct rotation information (google)

Linked Issues

PR Checklist

Additional information

Rear Front
2523-rear 2523-front

@phunkeler phunkeler marked this pull request as draft February 16, 2025 05:45
@phunkeler phunkeler changed the title sync display rotation w/ use case [Android] Sync Image Capture Use Case w/ Display Rotation Feb 16, 2025
@phunkeler phunkeler mentioned this pull request Feb 16, 2025
2 tasks
@phunkeler phunkeler changed the title [Android] Sync Image Capture Use Case w/ Display Rotation [Android] Sync ImageCapture Use Case w/ Display Rotation Feb 16, 2025
@phunkeler phunkeler marked this pull request as ready for review February 16, 2025 15:55
@TheCodeTraveler TheCodeTraveler enabled auto-merge (squash) March 6, 2025 18:38
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phunkeler!!

@bijington
Copy link
Contributor

@phunkeler thank you for this! Can I check what devices you tested this on? Things may well be better with CameraX but I recall that Samsung devices used to do the opposite to what was expected in previous versions

@TheCodeTraveler TheCodeTraveler merged commit 9233b73 into CommunityToolkit:main Mar 6, 2025
10 checks passed
@phunkeler
Copy link
Contributor Author

@phunkeler thank you for this! Can I check what devices you tested this on? Things may well be better with CameraX but I recall that Samsung devices used to do the opposite to what was expected in previous versions

Hi @bijington, the .gif above is from a Samsung Galaxy S21 (API 34) but I also tested it on a Samsung Galaxy XCover6 Pro (API 34).

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
@phunkeler phunkeler deleted the bug/n2096 branch May 4, 2025 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CamaraView Photo Rotate

4 participants