Restrict AddPopup extensions to View to avoid ContentPage from being allowed

[bijington]

…allowed

Description of Change

Restricts the types allowed into AddXPopup extension methods to prevent ContentPage from being passed in.

Linked Issues

• Fixes Popup V2 - Can't locate View Model #2713

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

[Copilot]

Pull Request Overview

The PR tightens the generic constraints on AddPopup extension methods to only allow View types (preventing ContentPage usage) and updates related XML docs.

• Changed all TPopupView constraints from IView to View
• Updated <typeparam> XML comments to reference View instead of IView
• Ensured AddPopup overloads correctly restrict input types

Comments suppressed due to low confidence (3)

src/CommunityToolkit.Maui/Extensions/ServiceCollectionExtensions.shared.cs:38

• The XML doc indicates TPopupViewModel is constrained to INotifyPropertyChanged, but the code uses where TPopupViewModel : notnull. Update the constraint or the doc to match.

/// <typeparam name="TPopupViewModel">The type of the ViewModel to add. Constrained to 

src/CommunityToolkit.Maui/Extensions/ServiceCollectionExtensions.shared.cs:52

• This overload is AddSingletonPopup, but the doc still says ServiceLifetime.Transient. It should reference ServiceLifetime.Singleton.

/// <see cref="IServiceCollection"/> with <see cref="ServiceLifetime.Transient"/> lifetime.

src/CommunityToolkit.Maui/Extensions/ServiceCollectionExtensions.shared.cs:68

• The documentation for the AddSingletonPopup<TPopupView, TPopupViewModel> overload still mentions Transient lifetime; this should be updated to Singleton.

/// <see cref="IServiceCollection"/> with <see cref="ServiceLifetime.Transient"/> lifetime.

[TheCodeTraveler]

Thanks Shaun! I've added the breaking-change label since this technically modifies our API surface.

Let's discuss internally if it merits another major version. It may not impact many (if any) developers.

[bijington]

Thanks Shaun! I've added the breaking-change label since this technically modifies our API surface.

Let's discuss internally if it merits another major version. It may not impact many (if any) developers.

Yeah that's fair. Although it is breaking the rules we're too lax and if a dev provided something like ContentPage it broke. I guess there was the possibility of a dev creating their own IView implementation but I suspect that chance is very low