[Popup] Add DefaultPopupOptionsSettings and DefaultPopupSettings to .UseMauiCommunityToolkit(Options)

[TheCodeTraveler]

Description of Change

This PR grants developers the capability to set global default values for every popup in their app using DefaultPopupOptionsSettings and DefaultPopupSettings in.UseMauiCommunityToolkit(Options):

.UseMauiCommunityToolkit(static options =>
{
  options.SetPopupDefaults(new DefaultPopupSettings
  {
	  CanBeDismissedByTappingOutsideOfPopup = true,
	  BackgroundColor = Colors.Orange,
	  HorizontalOptions = LayoutOptions.End,
	  VerticalOptions = LayoutOptions.Start,
	  Margin = 72,
	  Padding = 4
  });
  options.SetPopupOptionsDefaults(new DefaultPopupOptionsSettings
  {
	  CanBeDismissedByTappingOutsideOfPopup = true,
	  OnTappingOutsideOfPopup = () => hasOnTappingOutsideOfPopupExecuted = true,
	  PageOverlayColor = Colors.Orange,
	  Shadow = null,
	  Shape = null
  });
})

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: Add DefaultPopupSettings and DefaultPopupOptionsSettings MicrosoftDocs/CommunityToolkit#574

Additional information

This PR also fixes a bug where View.Padding was improperly being passed through to PopupBorder.Padding

[Copilot]

Pull Request Overview

This PR introduces global default settings for popups and popup options, allowing developers to configure defaults via UseMauiCommunityToolkit(Options), and refactors existing default classes. It also fixes how popup padding is applied and updates related bindings and tests.

• Introduce DefaultPopupSettings and DefaultPopupOptionsSettings records and remove old static defaults.
• Update PopupPage, Popup, converters, and Options to use the new default records and accept nullable options.
• Refresh unit tests and sample to align with the new default-setting APIs.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs	Accept nullable options, bind new defaults, update converters
src/CommunityToolkit.Maui/Views/Popup/PopupOptions.shared.cs	Change bindable property defaults to use Options.DefaultPopupOptionsSettings
src/CommunityToolkit.Maui/Views/Popup/Popup.shared.cs	Initialize Popup defaults from Options.DefaultPopupSettings
src/CommunityToolkit.Maui/Primitives/Defaults/PopupOptionsDefaults.shared.cs	Remove obsolete static defaults class
src/CommunityToolkit.Maui/Primitives/Defaults/PopupDefaults.shared.cs	Remove obsolete static defaults class
src/CommunityToolkit.Maui/Primitives/DefaultPopupSettings.cs	Add DefaultPopupSettings record
src/CommunityToolkit.Maui/Primitives/DefaultPopupOptionsSettings.cs	Add DefaultPopupOptionsSettings record
src/CommunityToolkit.Maui/Options.cs	Add storage and setters for default popup settings and options
src/CommunityToolkit.Maui/Extensions/PopupExtensions.shared.cs	Drop fallback to PopupOptions.Empty, rely on nullable handling
samples/CommunityToolkit.Maui.Sample/MauiProgram.cs	Invoke new SetPopupDefaults and SetPopupOptionsDefaults

Comments suppressed due to low confidence (5)

src/CommunityToolkit.Maui/Options.cs:17

• The #error directive will block compilation for .NET 10 and later; remove the conditional branch and public constructor to prevent build failures and streamline the Options API.

#error Remove .NET 9 code now that we're upgrading to .NET 10; Options should not have a public constructor, only public methods. Having a public constructor allows developers to override the values set when using AppBuilderExtensions    

src/CommunityToolkit.Maui/Primitives/DefaultPopupSettings.cs:32

• [nitpick] The nested class PopupDefaults inside DefaultPopupSettings conflicts in naming with the removed global PopupDefaults; consider renaming it to clarify its scope (e.g., DefaultValues).

	static class PopupDefaults

src/CommunityToolkit.Maui/Primitives/DefaultPopupOptionsSettings.cs:29

• [nitpick] The nested class PopupOptionsDefaults inside DefaultPopupOptionsSettings shares a name with the old global defaults; renaming it (e.g., to DefaultValues) would reduce confusion.

	static class PopupOptionsDefaults

src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs:138

• This binding no longer uses the VerticalOptionsConverter, so default fallback values won't be applied when view.VerticalOptions is Fill; add the converter to apply Options.DefaultPopupSettings.VerticalOptions.

		popup.SetBinding(Popup.VerticalOptionsProperty, static (View view) => view.VerticalOptions, source: view, mode: BindingMode.OneWay);

src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs:139

• This binding no longer uses the HorizontalOptionsConverter, so default fallback values won't be applied when view.HorizontalOptions is Fill; add the converter to apply Options.DefaultPopupSettings.HorizontalOptions.

		popup.SetBinding(Popup.HorizontalOptionsProperty, static (View view) => view.HorizontalOptions, source: view, mode: BindingMode.OneWay);

[bijington]

I know I initiated this thought process but I wanted to play devils advocate a little before we go further. I do like the idea of allowing developers to define defaults but I want to float some thoughts by you all to see what you think:

• We should allow developers to control values through a Style which I believe is currently broken ([BUG] Padding and Margin are not applied to the Popup class of Popup2 by Style attribute #2747). I am not suggesting we fix it in this PR but I don't want this PR to make it any more difficult to fix
• Perhaps a way to reduce the complexity of multiple possible values for things like CanDismiss... is to accept PopupOptions when passing in a View to the ShowPopup methods and not when passing in a Popup? I know this breaks some symmetry but with Popup but that might not be a bad thing. - I originally considered this but have struck it through because I think it causes more issues than it solves.
• I would like us to make it possible for properties like BackgroundColor and PageOverlayColor to be set using an AppThemeBinding - yes it would be possible via a Style but should it be possible as a default too?

[bijington]

Hey @TheCodeTraveler good work on this! I have added 2 comments - one to help me understand what needs to be documented and another mostly just explaining why I took so long to review. Feel free to resolve the comments and merge.