Skip to content

Fire Action PopupOptions.OnTappingOutsideOfPopup when Android Back Button Pressed #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025
Merged

Fire Action PopupOptions.OnTappingOutsideOfPopup when Android Back Button Pressed #2799

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f8f222
Use `tapOutsideOfPopupCommand` inside `OnBackButtonPressed`
TheCodeTraveler Jul 8, 2025
de8a9b1
Add Comments
TheCodeTraveler Jul 8, 2025
6e8cf46
Remove unused field
TheCodeTraveler Jul 8, 2025
cf3d97e
Merge branch 'main' into Fire-`OnTappingOutsideOfPopup`-Action-when-A…
TheCodeTraveler Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/CommunityToolkit.Maui/Views/Popup/PopupPage.shared.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,11 @@ public async Task CloseAsync(PopupResult result, CancellationToken token = defau

protected override bool OnBackButtonPressed()
{
// Only close the Popup if CanBeDismissedByTappingOutsideOfPopup is true
if (GetCanBeDismissedByTappingOutsideOfPopup(popup, popupOptions))
// When the Android Back Button is tapped, we only close the Popup if the tapOutsideOfPopupCommand can execute
// In other words, we'll only close the Popup when CanBeDismissedByTappingOutsideOfPopup is true
if (tapOutsideOfPopupCommand.CanExecute(null))
{
CloseAsync(new PopupResult(true), CancellationToken.None).SafeFireAndForget();
tapOutsideOfPopupCommand.Execute(null);
}

// Always return true to let the Android Operating System know that we are manually handling the Navigation request from the Android Back Button
Expand Down
Loading