-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure Popup will set the Window at the Content #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Pedro! I just tried the reproduction sample from #629 using the NuGet Package from this PR (CommunityToolkit.Maui.1.0.0-build-674.80100.nupkg
), and the iOS Lotte Animation is still frozen inside of the Popup.
Android looks good now!
iOS / macOS Animation in Popup Still Frozen | Android (Looks good!) |
---|---|
@brminnick thanks for testing on iOS, I'll give a try here, I hope the tooling works after this update |
So... This is kinda funny, and I'm not sure if the bug is here or in .NET MAUI. So looks like a timing issue(?) cc: @PureWeen PopupLottie.mp4 |
@pictos - Can we merge this since it fixes the bug on Android? As long as we keep the Bug open, we should be good right? |
@brminnick yes, we can. I'll create a new issue related to the Window property, and link this PR to it. I'll also do a couple more changes on the PR during this week, I found some places where this can be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved bug fix for Android
Description of Change
.NET MAUI has the concept of
Window
inside some controls, when we implemented thePopup
we don't care (or this concept diudn't exist yet) about it, since it should be set automagically, but this isn't the case here becausePopup
is anElement
so we need to help the framework to set it.Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRAdditional information