Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building in Codespaces, install net7 in devcontainer #155

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Arlodotexe
Copy link
Member

Closes #153

@Arlodotexe Arlodotexe added bug Something isn't working dev loop ➰ labels Jul 21, 2023
@Arlodotexe Arlodotexe marked this pull request as ready for review July 21, 2023 18:14
@Arlodotexe Arlodotexe enabled auto-merge (squash) July 21, 2023 20:12
@michael-hawker michael-hawker force-pushed the fix/codespace/building branch from bd1cba0 to 017eab7 Compare July 21, 2023 21:03
@michael-hawker michael-hawker disabled auto-merge July 21, 2023 21:03
@michael-hawker michael-hawker enabled auto-merge (rebase) July 21, 2023 21:03
@michael-hawker
Copy link
Member

Tests failed, if it fails again we can probably merge as it is unrelated. Don't think have an update from runner team. Based on what I was reading it could be we have a test maybe that intermittently throws and the exception isn't caught? But since we haven't changed the tests since this has been an issue, I'd be surprised...

@michael-hawker michael-hawker merged commit 7d43a56 into main Jul 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/codespace/building branch July 21, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev loop ➰
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespace Config doesn't have proper .NET SDK installed
2 participants