BladeItem Brushes somehow causes app crash in secondary view

[JustinXinLiu]

I came across this StackOverflow question and was able to find a workaround for it - turned out the issue is related to two brush properties defined in BladeItem.

My answer works but I feel like this could be a bug in the framework as I can't see why they would cause this kind of hard crash.

[IbraheemOsama]

Ping @skendrot

[skendrot]

For version 2.0 I would like to see these properties removed in favor of Title, TitleTemplate, and CloseButtonContent, CloseButtonContentTemplate. How's that sound @nmetulev?

Not sure why setting the properties would cause whatever issue this is to go away. They both default to Black

public static readonly DependencyProperty TitleBarForegroundProperty = DependencyProperty.Register(
       nameof(TitleBarForeground), 
       typeof(Brush), 
       typeof(BladeItem), 
       new PropertyMetadata(new SolidColorBrush(Colors.Black)));

[JustinXinLiu]

Yeah that's what I thought. The code looks fine to me. I will raise it with the UI team.

[nmetulev]

@skendrot, Agree, I'll add this to 2.0 milestone. Is there a quick fix we can add for 1.5?

[skendrot]

Note: I haven't tested the issue
It's possible setting the foregrounds in the default style would fix this.

But, it's a very small corner case and it would be fixed in the 2.0 version by removing them in favor of Templates

[nmetulev]

OK, let's keep it for 2.0 then

[nmetulev]

ping

[nmetulev]

Moving this to 2.1. Should we simply add the default brushes?

[windowstoolkitbot]

This issue seems inactive. It will automatically be closed in 14 days if there is no activity.

[nmetulev]

ping @JustinXinLiu, @skendrot, should we just add the setters in default styles for this one? Too late to do any breaking changes

[JustinXinLiu]

Yeah that'd be the easiest way to fix it for now, unless @skendrot has already started the changes he proposed earlier?

[skendrot]

I'll work on getting the above properties added without making breaking changes