Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleApp ValueHolder doesn't compare Values for Property Change Notification #1656

Closed
michael-hawker opened this issue Nov 27, 2017 · 0 comments
Assignees
Milestone

Comments

@michael-hawker
Copy link
Member

From discussion in #1399

There's a bug using the above though if the ValueHolder is changed, as it uses objects the != comparison here. I was pretty surprised, but it's because we're going through a object type conversion the enum value comparison isn't used unless we do if (!_value.Equals(value)) instead. See this article.

I also noticed we have some dead code in some of the samples which try and set their own datacontext when we do it for them now. All these sections can be removed. I'll file a bug to track these separately.

I'll submit a fix for these two things later this week.

@michael-hawker michael-hawker self-assigned this Nov 27, 2017
@nmetulev nmetulev added this to the v2.2 milestone Nov 27, 2017
nmetulev added a commit that referenced this issue Nov 28, 2017
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants