Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current WCT solution does not build when .NET 5 preview is installed #3339

Open
jeromelaban opened this issue Jun 10, 2020 · 8 comments
Open
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 help wanted Issues identified as good community contribution opportunities

Comments

@jeromelaban
Copy link
Contributor

Describe the bug

When building the Microsoft.Toolkit.Services project, the WPFPopup XAML page for the net462 target is not getting its .i.g.cs content generated properly, causing missing members compilation errors.

Steps to Reproduce

Install .NET 5.0.100-preview.6.20277.5, build the solution.

Additional context

This looks like a .NET 5 issue, where the MarkupCompilePass1 does not seem to be executed at all, even though Page ItemGroup items are present.

As a workaround, adding this to the global.json file works around the issue:

  "sdk": {
    "version": "3.1.201",
    "rollForward": "latestPatch"
  },
@jeromelaban jeromelaban added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jun 10, 2020
@ghost ghost added the needs triage 🔍 label Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

Hello jeromelaban, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

Thanks @jeromelaban for highlighting the issue!!

@Kyaa-dost Kyaa-dost added the help wanted Issues identified as good community contribution opportunities label Jun 10, 2020
@michael-hawker
Copy link
Member

Thanks @jeromelaban we hadn't noticed an issue yet, but had also only last tested with preview4 on our machines.

Do you know if there's a .NET issue open for anything like this?

FYI @azchohfi

@jeromelaban
Copy link
Contributor Author

I do not know if there is an existing one. Mentioned it here as I'm not sure where it should be going :)

@michael-hawker
Copy link
Member

@tommcdon @MichalStrehovsky any thoughts on what @jeromelaban is seeing here? Or know the right folks to pull in to this?

I have .NET 5 Preview 4.20258.7 on my machine and have no troubles, so this appears like a regression in the .NET 5 Preview?

@tommcdon
Copy link

@tommcdon @MichalStrehovsky any thoughts on what @jeromelaban is seeing here? Or know the right folks to pull in to this?

I have .NET 5 Preview 4.20258.7 on my machine and have no troubles, so this appears like a regression in the .NET 5 Preview?

Here is the runtime issue for your reference: dotnet/runtime#37672.

@jeromelaban
Copy link
Contributor Author

jeromelaban commented Jun 11, 2020

@tommcdon Is it expected that the removal of WinRT affects the WPF the toolchain ?

@tommcdon
Copy link

@tommcdon Is it expected that the removal of WinRT affects the WPF the toolchain ?

Adding @ryalanms who might be able to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

4 participants