New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading control sample: blurring effect is wrong #3359

Closed

1 task

sylveon opened this issue Jun 23, 2020 · 12 comments · Fixed by #3488

Closed

1 task

Loading control sample: blurring effect is wrong #3359

sylveon opened this issue Jun 23, 2020 · 12 comments · Fixed by #3488

Assignees

Labels

bug 🐛 Completed 🔥 help wanted needs attention 👋 needs triage 🔍 sample app 🖼

Milestone

sylveon commented Jun 23, 2020

Describe the bug

In the toolkit sample, the blurring occurs on the logo rather than the background.

Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work: No idea

Steps to Reproduce

Steps to reproduce the behavior:

Open the community toolkit sample app
Navigate to Controls > Loading
Click "Loading control with logo and blurring when requested"

Expected behavior

The background is blurred and the WCT logo is not

Screenshots

Environment

Community Toolkit Sample App Version 6.1
Windows 10 19041

sylveon added the bug 🐛 label

ghost added the needs triage 🔍 label

ghost commented Jun 23, 2020

Hello sylveon, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

Contributor

Kyaa-dost commented Jun 23, 2020

@sylveon I have just tried and was not able to reproduce the issue. Based on the image you provided does the logo does not seem blur?

Author

sylveon commented Jun 23, 2020

The issue is that the logo blurs rather than the background

Contributor

Kyaa-dost commented Jun 23, 2020

@sylveon ok that makes sense. Do you want to work on this issue and create a PR?

Author

sylveon commented Jun 23, 2020

I've no idea how to fix it, just stumbled on it when toying with the app

Contributor

Kyaa-dost commented Jun 23, 2020

@sylveon Thanks for highlighting the issue. Let's see if any other community member is able to pick this up.

Kyaa-dost added help wanted sample app 🖼 labels

ghost added the needs attention 👋 label

ghost commented Jul 8, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

5 similar comments

ghost commented Jul 24, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

ghost commented Jul 24, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

ghost commented Aug 8, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

ghost commented Aug 23, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

ghost commented Sep 7, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

Sergio0694 self-assigned this

Sergio0694 added this to the 7.0 milestone

Sergio0694 mentioned this issue

Fixed incorrect blur in loading sample #3488

Merged

7 tasks

ghost added the In-PR 🚀 label

ghost closed this as completed in #3488

ghost pushed a commit that referenced this issue


          Fixed incorrect blur in loading sample (#3488)

a7f8976

## Fixes #3359
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

 - Bugfix
 - Sample app changes
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
The blur is incorrectly applied to the loading icon on top of the sample page content:

![image](https://user-images.githubusercontent.com/10199417/93781807-0cb16600-fc2a-11ea-9336-d286bcae3aa0.png)

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
The blur is now applied to the content of the page, with the icon being clearly visible:

![image](https://user-images.githubusercontent.com/10199417/93781861-1fc43600-fc2a-11ea-905d-7e2b82210361.png)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] ~~Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->~~
- [X] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~
- [ ] ~~Tests for the changes have been added (for bug fixes / features) (if applicable)~~
- [ ] ~~Header has been added to all new source files (run *build/UpdateHeaders.bat*)~~
- [ ] ~~Contains **NO** breaking changes~~

ghost added Completed 🔥 and removed In-PR 🚀 labels

ghost locked as resolved and limited conversation to collaborators

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.