Opening/Opened/Dismissed events support for InAppNotification. #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give developers more control over InAppNotification management. Dismissed event has its own EventArgs with OpenedTime/DismissedTime props.
|
Sad, I think we will have conflicts with #1441 |
|
Hey @bkaankose, thank you so much for crating this PR. I believe @Odonno submitted a similar PR (#1441) and I'll encourage you to review that PR to make sure it doesn't covers the same scenarios. The two PRs seem to add the same feature. |
|
My bad, wasn't paying attention lately. #1441 actually covers what my PR brings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give developers more control over InAppNotification management. Dismissed event has its own EventArgs with OpenedTime/DismissedTime props.
Listed in #1430