Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all nuget packages go in the same folder #1546

Merged
merged 3 commits into from
Apr 30, 2018

Conversation

dotMorten
Copy link
Contributor

Makes it easier to use a single folder as your nuget repository for testing, rather than having to dig around all bin folders and combine them manually.

PR Type

Build output folder

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build or CI related changes
[ ] Documentation content changes
[ ] Sample app changes
[x] Other... Please describe: Restructure output of nuget packages

What is the current behavior?

Nuget packages are spread out among each project;s sub folders.

PR Checklist

  • [N/A] Tested code with current supported SDKs
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] Sample in sample app has been added / updated (for bug fixes / features)
  • [N/A] Tests for the changes have been added (for bug fixes / features) (if applicable)

What is the new behavior?

This change unifies where nuget packages are copied to (Output\NuGet\Release|Debug\*.nupkg)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

…a single folder as your nuget repository for testing
@nmetulev
Copy link
Contributor

Build failed at first, but after running it again seems to have completed. However, no artifacts were generated.

@dotMorten
Copy link
Contributor Author

@nmetulev I updated the appveyor.yml file to look for the artifacts elsewhere, but not sure if appveyor itself needs updating?

@nmetulev
Copy link
Contributor

It looks like it's looking at the new location:

image

but the nugets are still at the old location:

image

@nmetulev
Copy link
Contributor

@dotMorten, Up?

@dotMorten
Copy link
Contributor Author

@nmetulev aaah I see. I think the build script does its own thing

@WilliamABradley
Copy link
Contributor

@nmetulev
Copy link
Contributor

nmetulev commented Nov 7, 2017

@dotMorten, all the nugets right now go to the bin/nupkg folder. is this needed?

@nmetulev
Copy link
Contributor

@dotMorten, is this PR necessary. Seems like everything is working right now

@dotMorten
Copy link
Contributor Author

@nmetulev The packages go in the right folder when you use powershell. When you use the right-click->pack in Visual Studio, it goes in the project's output folder. It makes testing specific nuget packages a lot harder, because you have to go and copy them into the same folder so the dependencies can be resolved.

@nmetulev
Copy link
Contributor

Ah, I see. I think you probably need to just revert appveyor.yml

@windowstoolkitbot
Copy link

This PR seems inactive. @dotMorten Do you need help to complete this issue?

1 similar comment
@windowstoolkitbot
Copy link

This PR seems inactive. @dotMorten Do you need help to complete this issue?

@nmetulev
Copy link
Contributor

@dotMorten, I updated your branch so all nugets go in the existing folder. Would this work?

@windowstoolkitbot
Copy link

This PR seems inactive. @dotMorten Do you need help to complete this issue?

@michael-hawker michael-hawker merged commit e4fa742 into master Apr 30, 2018
@Kyaa-dost Kyaa-dost deleted the dotMorten/SetNugetOuputPath branch August 25, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants