Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Negative index validation in TextBoxRegEx #2293

Merged
merged 6 commits into from
Jul 13, 2018
Merged

[Fix] Negative index validation in TextBoxRegEx #2293

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a0739a
Perform a negative control of the startIndex variable by leaving this…
Jul 11, 2018
99d0605
Merge branch 'master' into fix/textboxregex-crashes-when-caret-is-at-…
nmetulev Jul 11, 2018
f780b2b
Merge branch 'master' into fix/textboxregex-crashes-when-caret-is-at-…
skendrot Jul 11, 2018
890bc9c
Merge branch 'master' into fix/textboxregex-crashes-when-caret-is-at-…
kbrons Jul 12, 2018
6c1c870
Merge branch 'master' into fix/textboxregex-crashes-when-caret-is-at-…
kbrons Jul 13, 2018
88ca0a2
Merge branch 'master' into fix/textboxregex-crashes-when-caret-is-at-…
kbrons Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Microsoft.Toolkit.Uwp.UI/Extensions/TextBoxRegEx/TextBoxRegex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private static void ValidateTextBox(TextBox textbox, bool force = true)
{
if (validationModel == ValidationMode.Dynamic)
{
int selectionStart = textbox.SelectionStart - 1;
int selectionStart = textbox.SelectionStart == 0 ? textbox.SelectionStart : textbox.SelectionStart - 1;
textbox.Text = textbox.Text.Remove(selectionStart, 1);
textbox.SelectionStart = selectionStart;
}
Expand Down