-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Toolkit.Mvvm package (part 2) #3413
Merged
12 commits merged into
CommunityToolkit:master
from
Sergio0694:feature/mvvm-toolkit-part2
Aug 11, 2020
Merged
Microsoft.Toolkit.Mvvm package (part 2) #3413
12 commits merged into
CommunityToolkit:master
from
Sergio0694:feature/mvvm-toolkit-part2
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
michael-hawker
approved these changes
Aug 10, 2020
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
michael-hawker
approved these changes
Aug 11, 2020
azchohfi
approved these changes
Aug 11, 2020
Hello @azchohfi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merge ⚡
bug 🐛
An unexpected issue that highlights incorrect behavior
improvements ✨
.NET
Components which are .NET based (non UWP specific)
optimization ☄
Performance or memory usage improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3229
NOTE
Marking this not as a draft so that the CI will run, but added the "DO NOT MERGE ⚠" tag as we might come up with further improvements to add to this PR before actually deciding to merge this and finalize the package.
PR Type
What kind of change does this PR introduce?
Notable changes
This PR includes some refinements and tweaks to the
Microsoft.Toolkit.Mvvm
package, like:ObservableRecipient.SetProperty
overloads withExpression<Func<T>>
andbool broadcast
paramsMessenger.Type2.Equals
(just to be extra sure)ObservableRecipient.Set<T>(ref T, T, string)
(missingEqualityComparer<T>.Default.Equals
inlining)PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates