Fixed ImageEx.CornerRadius property #3529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3528
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
ImageEx.CornerRadius
property isn't working anymore.What is the new behavior?
Modifying
ImageEx.CornerRadius
works correctly.Additional detail
With #3440, we bumped the minimum SDK to 1809 (build 17763), which is the first one with the
CornerRadius
being available in theControl
class. I suspect building the controls package with that minimum SDK caused an issue withImageEx
defining theCornerRadius
property again (usingnew
), so that the XAMLTemplateBinding
ended up failing to find the correct property to bind to. It might also be because setting the property in XAML ended up setting the value for the incorrect duplicate one, so that binding was never update. Regardless, with that minimum version available there's no reason to duplicate that property in the first place, we can just use the built-in one and bind to that. This PR removes that duplicate property, fixing the issue.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates