Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImageEx.CornerRadius property #3529

Merged
1 commit merged into from
Oct 15, 2020

Conversation

Sergio0694
Copy link
Member

Fixes #3528

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The ImageEx.CornerRadius property isn't working anymore.

What is the new behavior?

Modifying ImageEx.CornerRadius works correctly.

Additional detail

With #3440, we bumped the minimum SDK to 1809 (build 17763), which is the first one with the CornerRadius being available in the Control class. I suspect building the controls package with that minimum SDK caused an issue with ImageEx defining the CornerRadius property again (using new), so that the XAML TemplateBinding ended up failing to find the correct property to bind to. It might also be because setting the property in XAML ended up setting the value for the incorrect duplicate one, so that binding was never update. Regardless, with that minimum version available there's no reason to duplicate that property in the first place, we can just use the built-in one and bind to that. This PR removes that duplicate property, fixing the issue.

NOTE: this is technically a breaking change as we're removing a public property, but users should effectively not really notice any difference, unless they were for some reason setting that very specific property through reflection, which is highly unlikely. Adding the tag for correctness, since this is still in fact a breaking change. Not likely to be noticed though 😄

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ introduce breaking changes 💥 labels Oct 10, 2020
@Sergio0694 Sergio0694 added this to the 7.0 milestone Oct 10, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost October 10, 2020 14:45
@ghost
Copy link

ghost commented Oct 15, 2020

Hello @RosarioPulella!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c6c6602 into CommunityToolkit:master Oct 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ introduce breaking changes 💥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageEx.CornerRadius property not working anymore
3 participants