Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the Sample app needing to be rebuilt even when nothing has changed #3558

Merged

Conversation

mrlacey
Copy link
Contributor

@mrlacey mrlacey commented Nov 7, 2020

Fixes #3332

Stop the sample app from always triggering a rebuild, even if no code has been changed.

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: Change in compilation behavior of the Sample App

What is the current behavior?

VS will always rebuild the sample app when launched for debugging.

What is the new behavior?

Now VS will only rebuild the code if something has changed.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

All unchecked options above are not applicable

Other information

@ghost
Copy link

ghost commented Nov 7, 2020

Thanks mrlacey for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost November 7, 2020 19:04
@ghost ghost added bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼 labels Nov 7, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Nov 9, 2020
@michael-hawker
Copy link
Member

Thanks @mrlacey! This worked great for me. Didn't realize it was such a simple thing!

@RosarioPulella or @Kyaa-dost want to test this out quick?

@ghost
Copy link

ghost commented Nov 9, 2020

Hello @michael-hawker!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mrlacey! This is ready to 🚀 🚀

CC: @michael-hawker

@ghost ghost merged commit e8e2bcf into CommunityToolkit:master Nov 9, 2020
@mrlacey
Copy link
Contributor Author

mrlacey commented Nov 10, 2020

Didn't realize it was such a simple thing!

Simple if you ignore the hours I've previously spent reading through diagnostic output logs to know where to look for issues like this.

@mrlacey mrlacey deleted the i3332-SampleAppBuildsUnnecessarily branch November 10, 2020 16:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior sample app 🖼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SampleApp rebuilds even if no changes
3 participants