-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ObjectExtensions -> ObjectMarshal #3760
Refactor ObjectExtensions -> ObjectMarshal #3760
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, quick question. Otherwise I'm good.
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 42 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All the
object
helpers are exposed as extensions through theObjectExtensions
class. These methods are all pretty dangerous and should only be used in very specific scenarios, but having them as extensions (and onobject
too) means they pop up in IntelliSense everywhere, as soon as a consumer references theMicrosoft.Toolkit.HighPerformance
package. This is not ideal and could be confusing for consumers, or at least just make the IntelliSense window more crowded for no real benefit.What is the new behavior?
The
object
extensions have been moved to a static helper classObjectMarshal
, and they're no longer extensions.PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates