Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ObjectExtensions -> ObjectMarshal #3760

Merged

Conversation

Sergio0694
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Refactoring with some API changes

What is the current behavior?

All the object helpers are exposed as extensions through the ObjectExtensions class. These methods are all pretty dangerous and should only be used in very specific scenarios, but having them as extensions (and on object too) means they pop up in IntelliSense everywhere, as soon as a consumer references the Microsoft.Toolkit.HighPerformance package. This is not ideal and could be confusing for consumers, or at least just make the IntelliSense window more crowded for no real benefit.

What is the new behavior?

The object extensions have been moved to a static helper class ObjectMarshal, and they're no longer extensions.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added introduce breaking changes 💥 improvements ✨ high-performance 🚂 Issues/PRs for the Microsoft.Toolkit.HighPerformance package .NET Components which are .NET based (non UWP specific) labels Feb 17, 2021
@Sergio0694 Sergio0694 added this to the 7.0 milestone Feb 17, 2021
@ghost ghost added the in progress 🚧 label Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quick question. Otherwise I'm good.

@ghost
Copy link

ghost commented Feb 17, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 42 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added the next preview ✈️ Label for marking what we want to include in the next preview release for developers to try. label Feb 17, 2021
@Sergio0694 Sergio0694 merged commit 065ebe4 into CommunityToolkit:master Feb 17, 2021
@Sergio0694 Sergio0694 deleted the refactoring/object-marshal branch February 17, 2021 19:00
@ghost ghost added Completed 🔥 and removed in progress 🚧 labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ Completed 🔥 high-performance 🚂 Issues/PRs for the Microsoft.Toolkit.HighPerformance package improvements ✨ introduce breaking changes 💥 .NET Components which are .NET based (non UWP specific) next preview ✈️ Label for marking what we want to include in the next preview release for developers to try.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants