Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification Group property being overwritten in unpackaged apps #3836

Merged
2 commits merged into from
Mar 19, 2021

Conversation

andrewleader
Copy link
Contributor

@andrewleader andrewleader commented Mar 12, 2021

Fixes #3835

For unpackaged apps, we were accidently overwriting the Group property on toasts if developers were setting that. Thus, scenarios like #3835 where a progress bar toast is using both group and tag, updating the progress bar didn't work

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Group property gets overwritten

What is the new behavior?

Group property only gets written if developers didn't specify it

PR Checklist

Verified via...

  • Sample app modified with both using group and not using group for progress bar (and for removing toasts)
  • Final NuGet package in separate sample app (pending a build)

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 12, 2021

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Kyaa-dost March 12, 2021 21:10
@ghost ghost requested a review from Rosuavio March 12, 2021 21:10
@andrewleader andrewleader added this to the 7.0 milestone Mar 12, 2021
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Mar 12, 2021
@andrewleader andrewleader changed the base branch from master to dev/7.0.1 March 12, 2021 21:31
@michael-hawker michael-hawker modified the milestones: 7.0, 7.0.1 Mar 13, 2021
@michael-hawker
Copy link
Member

Seems straight-forward enough. @azchohfi @RosarioPulella want to take a look?

@ghost
Copy link

ghost commented Mar 18, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ae023fc into dev/7.0.1 Mar 19, 2021
@ghost ghost deleted the aleader/toast-progress-bar-fix branch March 19, 2021 18:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior notifications 🔔
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating toast progress bar from unpackaged desktop apps doesn't work when using Group+Tag
3 participants