Handle Assembly being null

[andrewleader]

Fixes #3861

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

If a desktop app's entry assembly is null, sending a notification throws an exception

What is the new behavior?

It'll correctly fall back to the process name and work.

PR Checklist

Customer verified that the fix fixes their problem!

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

Other information

[ghost]

Thanks andrewleader for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[michael-hawker]

Thanks @andrewleader for the quick fix! Did you take a quick audit of any other spots in the code that may also need null checks? (I mean while we're at it... 😋)

[andrewleader]

I didn't do a thorough check through for other possible null issues, I don't think there's anything else obvious... welcome to feedback from others but so far we've seemed good (and multiple partners have verified that things work end-to-end). If you have suggestions let me know :)

[michael-hawker]

@azchohfi looks like the SmokeTest issue is back? ☹

D:\a\1\s\SmokeTests\SmokeTest.csproj : warning NU1603: SmokeTest.Microsoft.Toolkit depends on Microsoft.Toolkit (>= 7.0.0-build.1042.g3f269cbeb0) but Microsoft.Toolkit 7.0.0-build.1042.g3f269cbeb0 was not found. An approximate best match of Microsoft.Toolkit 7.0.0-preview1 was resolved.

[ghost]

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[azchohfi]

@azchohfi looks like the SmokeTest issue is back? ☹

D:\a\1\s\SmokeTests\SmokeTest.csproj : warning NU1603: SmokeTest.Microsoft.Toolkit depends on Microsoft.Toolkit (>= 7.0.0-build.1042.g3f269cbeb0) but Microsoft.Toolkit 7.0.0-build.1042.g3f269cbeb0 was not found. An approximate best match of Microsoft.Toolkit 7.0.0-preview1 was resolved.

Nop. I just found out the reason this failed.
The BuildBits job started at 2:54PM, and it cloned the repo.
The SmokeTests job started at 3:32PM, and it also cloned the repo.
RIGHT in the middle of these two jobs, there was a new commit in the repository:
2c04c96

I'm checking if there is a way to force the same commit to be used on all jobs, and not latest on each job.