-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ReadOnlySpan2D<T>.Slice parameters order #3951
Fixed ReadOnlySpan2D<T>.Slice parameters order #3951
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@michael-hawker If we're considering doing a "hotfix release" before 7.1.0, I think this could be a good fit as well? 🙂 |
d9dca5a
to
4cdaf0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix!
Hello @Sergio0694! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
4cdaf0f
to
6e40cf8
Compare
This adjusts the tests following CommunityToolkit#3951
This adjusts the tests following CommunityToolkit/WindowsCommunityToolkit#3951
Fixup for #3353
PR Type
What kind of change does this PR introduce?
Overview
ReadOnlySpan2D<T>.Slice
has the incorrect ordering for theheight
andwidth
parameters, which is inverted with respect to those inSpan2D<T>.Slice
. This is an oversight from a refactor in the original PR, and as a result it also causes theReadOnlySpan2D<T>.this[Range, Range]
indexer to fail forReadOnlySpan2D<T>
. This PR fixes both issues and adds a new series of tests for the two indexers as well. We probably didn't notice this before since those indexers are not available on UWP 🤔PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templates