-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup, Format and Update Markdown files #4069
Fixup, Format and Update Markdown files #4069
Conversation
Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
5adcba4
to
85b32d2
Compare
8c4e150
to
ddaaa54
Compare
ddaaa54
to
629f9b4
Compare
f462359
to
f86d6c3
Compare
f86d6c3
to
7bf0181
Compare
7bf0181
to
2c2b396
Compare
Clean-up and Format with MarkdownLint
Fix-up MarkdownLint warnings
2c2b396
to
43cf51f
Compare
I checked the link you fixed and noticed the “readme.md” part of the markdown link to “supported SDKs” was removed. So in order to test it I also removed “readme.md” from the original link target:
* Old: https://github.com/CommunityToolkit/WindowsCommunityToolkit/readme.md#supported
* New: https://github.com/CommunityToolkit/WindowsCommunityToolkit/#supported
The new link points to the Features section of the project’s main page, which can also be accessed through https://github.com/CommunityToolkit/WindowsCommunityToolkit/#-features-mailbox.
Seems to me that the issue #4139 is fixed.
Should I close it?
|
That's the old link. The new link will be CommunityToolkit/WindowsCommunityToolkit#-features- when this PR is merged. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Nirmal4G! Think there's a way to add the Markdown Linter tool you used to the CI/Pipeline checks like we do with the header and stylecop formatting?
@michael-hawker Should be possible, I'm already looking into basic formatting, spelling checks via CI. I'll let you know. |
Fixes #4068
MarkdownLint
or similar tools, fix and format the markdown filesPR Type
What kind of change does this PR introduce?
What is the current behavior?
Markdown files have a lot of issues being reported from tools like
MarkdownLint
. They also use GitHub emoji identifiers.What is the new behavior?
Fixed and Formatted markdown files with
MarkdownLint
. Replaced GitHub emoji identifiers with actual emojis.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
rebase
on latestHEAD
and then commit, without updating from the latestHEAD
.Merge pull request #xxxx from repo/branch
, and commit message to either PR message or messages of individual commits. Theauto-merge
bot does this by default.