-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing controls to Visual Studio Toolbox #4070
Conversation
Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Marking as draft so we can know that it depends on #3894 first. |
5356098
to
7731d68
Compare
bd417d6
to
879f35c
Compare
Microsoft.Toolkit.Uwp.DeveloperTools/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
9f3f5f5
to
cc5dfe7
Compare
The MarkdownTextBlock's Assembly entry in the VS manifest is wrong, which is why the control was not present in the Toolbox. By simply updating to the correct Assembly Name lets the "MarkdownTextBlock" control to be validated and listed in the Visual Studio Toolbox.
There are many controls that were added since the original Design project was authored. Some of them were not added due to lack of docs w.r.t the Design project. So, We'll add them here and now instead. NOTE: If this works properly, then, we'll backport these changes to older versions.
When specified with "UIFramework" tag on the controls, we ensure that the controls doesn't list in places where UWP UI/WinUI is not supported.
cc5dfe7
to
34ba2c2
Compare
I'm having limited success with bringing in these items into my VS Toolbox. After tracking down the individual dlls that get built, and bringing them in via the "Choose Toolbox Items" dialog, and adding to the Universal Windows Components tab (which seems like the best option of the available choices), the best I can do is get some of the items to appear under a "All WPF Controls" header, and not the expected "Windows Toolkit" header (I had a Sample Page *.xaml file open, in the VS Designer): |
That's really weird @XAML-Knight, what version of VS are you running? They should appear automatically once the NuGet package is installed to a UWP project. You shouldn't have to do any manual config. Like here's our ContosoNotes sample: Or in another project after I just installed the first Toolkit package for the Input (looks like TokenzingTextBox was missing in our 7.1-preview): Just showed up instantly after installing NuGet. I'm on 16.11 now. |
Prior to this PR, the custom header is defined in the Visual Studio Toolbox manifest, not in the source. Also the control is not marked as UAP, so, that might be the reason it gets in WPF section. Please check to see if it's the same with this PR's NuGet! Also, I've marked these controls as UAP here, so, let me know if you want these controls to appear for WPF projects too!? |
When starting with a blank UWP app, I am now able to import & view the controls in my VS Toolbox (VS 2019 v16.10.3). However, to get to this point, I had to install each individual NuGet package by themselves (i.e., Microsoft.Toolkit.Uwp.UI.Controls.Input, Microsoft.Toolkit.Uwp.UI.Controls.Core, etc.), and wasn't able to bring in just one package, the all-up Microsoft.Toolkit NuGet package. I'm also now seeing duplicate controls in the Microsoft.UI.Xaml grouping in the VS Toolbox: |
No, not at this point |
@Nirmal4G would we have to do anything special for our meta |
Does installing You'd see duplicate controls because there might be two versions of WinUI installed in your solution. It was recently fixed as media controls had v2.5 and others having v2.6! but I don't know why it is happening again. @michael-hawker No, I don't think so but as I mentioned above, we should look into the meta package if it doesn't bring in the individual controls packages. |
Microsoft.Toolkit.Uwp.DeveloperTools/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Input/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Layout/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Markdown/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Media/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Core/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls.Primitives/VisualStudioToolsManifest.xml
Outdated
Show resolved
Hide resolved
34ba2c2
to
ec5b79e
Compare
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Installed the single meta package from the PR feed and everything LGTM: @XAML-Knight any luck on your side? If not, we can try and fix-forward and identify if it's particular to your environment for some reason or a particular VS version? |
No need for any changes - my out-of-box experience is the same as you're seeing. |
Fixes #3620
UIFramework
not mentioned).NOTE
When you have more than one version of controls packages containing
VisualStudioToolsManifest.xml
installed, you might see an entry for each version of the controls listed in the manifest. You can see the dicusssion below to know more.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Many controls don't appear in the VS IDE Toolbox.
What is the new behavior?
The Controls now appear in the VS IDE Toolbox.
PR Checklist
Please check if your PR fulfils the following requirements:
Other information
rebase
on latestHEAD
and then commit, without updating from the latestHEAD
.Merge pull request #xxxx from repo/branch
, and commit message to either PR message or messages of individual commits. Theauto-merge
bot does this by default.