Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed [ObservableProperty] for fields named "value" #4219

Conversation

Sergio0694
Copy link
Member

Closes #4216

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Using [ObservableProperty] on a field named "value" results in incorrect generated code.

What is the new behavior?

The generated code now works as expected.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ .NET Components which are .NET based (non UWP specific) mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package labels Sep 2, 2021
@Sergio0694 Sergio0694 added this to the 7.1 milestone Sep 2, 2021
@ghost
Copy link

ghost commented Sep 2, 2021

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker, azchohfi and Rosuavio September 2, 2021 10:33
Copy link
Contributor

@Rosuavio Rosuavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thought it would be quick one for you @Sergio0694, thanks!

@michael-hawker michael-hawker merged commit e4b8a68 into CommunityToolkit:main Sep 2, 2021
@Sergio0694 Sergio0694 deleted the bugfix/value-named-generated-property branch September 2, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior bugbash 🏗️ mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package .NET Components which are .NET based (non UWP specific)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVVM Source Generators: ObservablePropertyAttribute on member var named value
3 participants