Fixed exception type for Guard.IsNotNullOr[Empty|WhiteSpace]

[Sergio0694]

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

The Guard.IsNotNullOrEmpty and Guard.IsNotNullOrWhiteSpace APIs throw an ArgumentException even when the input is null. They should throw an ArgumentNullException in that case instead, for consistency.

What is the new behavior?

The right exception type is thrown. Same codegen for callers:

static void IsNotNullOrEmpty(string text, string name)
{
    if (!string.IsNullOrEmpty(text))
    {
        return;
    }

    ThrowArgumentExceptionForIsNotNullOrEmpty(text, name);
}

L0000: push ebp
L0001: mov ebp, esp
L0003: test ecx, ecx
L0005: je short L000f
L0007: cmp dword ptr [ecx+4], 0
L000b: jbe short L000f
L000d: pop ebp
L000e: ret
L000f: call dword ptr [0x290cc6fc]
L0015: int3

PR Checklist

Please check if your PR fulfills the following requirements:

• Tested code with current supported SDKs
• New component
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • If control, added to Visual Studio Design project
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes