-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/extended tree helpers #4333
Feature/extended tree helpers #4333
Conversation
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments, haven't gone through everything yet, but almost lost them accidently, so while I had some just going to send them over. 🙂
Microsoft.Toolkit.Uwp.UI/Extensions/DependencyObjectExtensions.cs
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.UWP/Extensions/Test_VisualTreeExtensions.cs
Outdated
Show resolved
Hide resolved
UnitTests/UnitTests.UWP/Extensions/Test_VisualTreeExtensions.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/DependencyObjectExtensions.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/DependencyObjectExtensions.cs
Outdated
Show resolved
Hide resolved
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Microsoft.Toolkit.Uwp.UI/Extensions/DependencyObjectExtensions.cs
Outdated
Show resolved
Hide resolved
0b28ee9
to
888ec93
Compare
Closes #4300
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some visual tree helpers are missing, and there is no way to specify the search type.
What is the new behavior?
Added the missing APIs discussed in the issue and listed below.
API breakdown
PR Checklist
Please check if your PR fulfills the following requirements: