Optimize Visual size sync through RelativeSizeAdjustment over expression animations #4397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All
Visual
objects created through our pipeline system are kept in sync with target objects through an expression animation.What is the new behavior?
We're now just using Visual.RelativeSizeAdjustment to achieve the same without the animation overhead.
I did test this in the sample app, but still adding the testing required tag as I'd like more validation on this.
Open questions
I'm wondering whether there's a way to also optimize this bit here by removing the animation:
WindowsCommunityToolkit/Microsoft.Toolkit.Uwp.UI/Extensions/VisualExtensions.cs
Lines 502 to 511 in 4a09bf0
Haven't yet figured out a solution though 🤔
EDIT: spoke with Chris, yeah there isn't a way to do this, nevermind 🤣
PR Checklist
Please check if your PR fulfills the following requirements: