Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive namespace declarations #4403

Merged

Conversation

XAML-Knight
Copy link
Contributor

Cleans Up excessive XAML namespace declarations on Sample Pages

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

Excessive XAML namespace declarations come along for the ride when user selects either BlurBehavior or SaturationBehavior sample pages are selected & loaded.

What is the new behavior?

Tidied up XAML namespace declarations for both BlurBehavior and SaturationBehavior.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Nov 29, 2021

Thanks XAML-Knight for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Sergio0694
Copy link
Member

Arlo

LetsGoTheRockGIF

@XAML-Knight XAML-Knight merged commit 5327002 into CommunityToolkit:main Dec 9, 2021
@michael-hawker michael-hawker added this to the 7.1.3 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants